Skip to content

Comments

ui: add support to change Account role for admins#9012

Merged
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:account-role-update-ui
May 1, 2024
Merged

ui: add support to change Account role for admins#9012
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:account-role-update-ui

Conversation

@yadvr
Copy link
Member

@yadvr yadvr commented Apr 30, 2024

This allow admins to change role of an account via UI by changing the roleid param to the updateAccount API/form.

This fixes #7756

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot 2024-04-30 at 4 48 32 PM

@yadvr
ui: add support to change Account role for admins
94b8f46 
This allow admins to change role of an account via UI by changing the
`roleid` param to the updateAccount API/form.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.19.1.0 milestone Apr 30, 2024
@yadvr yadvr mentioned this pull request Apr 30, 2024
Closed
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.93%. Comparing base (0271494) to head (94b8f46).
Report is 2 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #9012       +/-   ##
============================================
- Coverage     14.96%   4.93%   -10.04%     
============================================
  Files          5373     363     -5010     
  Lines        468970   29398   -439572     
  Branches      60770    5225    -55545     
============================================
- Hits          70183    1450    -68733     
+ Misses       391018   27795   -363223     
+ Partials       7769     153     -7616
Flag Coverage Δ
uitests 4.89% <ø> (+0.57%) ⬆️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sureshanaparti
Copy link
Contributor

sureshanaparti commented Apr 30, 2024

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Apr 30, 2024

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Apr 30, 2024

UI build failed: ✖️
(SL-JID-327)

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Apr 30, 2024

UI build failed: ✖️ (SL-JID-327)

code looks good, not sure why this would fail. (/me investigating)

@DaanHoogland DaanHoogland linked an issue Apr 30, 2024 that may be closed by this pull request
Provide an option to update role of an account from the UI #7756
Closed
@DaanHoogland
Copy link
Contributor

DaanHoogland commented Apr 30, 2024

UI build failed: ✖️ (SL-JID-327)

code looks good, not sure why this would fail. (/me investigating)

works on my laptop

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Apr 30, 2024

@blueorangutan ui

@blueorangutan
Copy link

blueorangutan commented Apr 30, 2024

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Apr 30, 2024

works/tested,
on thing I noticed is when admin want to grant domain admin rights to a user with role user:
image
I tried this in ROOT, where it should fail but with a better message and in a subdomain where this would be a perfectly acceptable action.
I'll create a new issue :(

@DaanHoogland DaanHoogland mentioned this pull request Apr 30, 2024
Closed
@blueorangutan
Copy link

blueorangutan commented Apr 30, 2024

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9012 (QA-JID-329)

@yadvr yadvr closed this Apr 30, 2024
@yadvr yadvr reopened this Apr 30, 2024
kiranchavala
kiranchavala approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested manually, able to update the role of account from the UI.

Proper error message is displayed if the operation is not permitterd

Screenshot 2024-05-01 at 2 29 05 PM Screenshot 2024-05-01 at 2 30 43 PM

@DaanHoogland DaanHoogland merged commit b91c387 into apache:4.19 May 1, 2024
@DaanHoogland DaanHoogland deleted the account-role-update-ui branch May 1, 2024 12:10
DaanHoogland added a commit that referenced this pull request May 6, 2024
@DaanHoogland
Merge release branch 4.19 to main
0d8f7d4 
* 4.19:
  linstor: disconnect-disk also search for resource name in Linstor (#9035)
  ui: add support to change Account role for admins (#9012)
  Use parameter dcId as wrapper to prevent NPE (#8986)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 17, 2024
@yadvr @dhslove
ui: add support to change Account role for admins (apache#9012)
0c3c0d3 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 17, 2024
@DaanHoogland @dhslove
Merge release branch 4.19 to main
a354e9f 
* 4.19:
  linstor: disconnect-disk also search for resource name in Linstor (apache#9035)
  ui: add support to change Account role for admins (apache#9012)
  Use parameter dcId as wrapper to prevent NPE (apache#8986)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

Assignees

No one assigned

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.19.1
Status: No status

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

Provide an option to update role of an account from the UI

6 participants

@yadvr @codecov-commenter @sureshanaparti @blueorangutan @DaanHoogland @kiranchavala